[fix] Data Access for PrebuiltTaskGraph fixed #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjfumero
added a commit
to jjfumero/TornadoVM
that referenced
this pull request
Aug 30, 2024
Improvements ~~~~~~~~~~~~~~~~~~ - beehive-lab#468: Cleanup Abstract Metadata Class. - beehive-lab#473: Add maven plugin to build TornadoVM source for the releases. - beehive-lab#474: Refactor `<X>TornadoDevice` to place common methods in the `TornadoXPUInterface`. - beehive-lab#482: Help messages improve when an out-of-memory exception is raised. - beehive-lab#484: Double-type for the trigonometric functions added in the `TornadoMath` class. - beehive-lab#487: Prebuilt API simplified. - beehive-lab#494: Add test to trigger unsupported features related to direct use of Memory Segments. - beehive-lab#509: Add a quick pass configuration to skip the heavy tests during active development. - beehive-lab#532: Improve thread scheduler to support RISC-V Accelerators from Codeplay. - beehive-lab#533: Support for scalar values to be passed via lambda expressions as tasks. - beehive-lab#538: `README` file updated. - beehive-lab#539: Refactor core classes and add new API methods to pass compilation flags to the low-level driver compilers (OpenCL, PTX and Level Zero). - beehive-lab#542: Tagged LevelZero JNI and Beehive Toolkit dependencies added in the build and installer. Compatibility ~~~~~~~~~~~~~~~~~~ - beehive-lab#465: Support for JDK 22 and GraalVM 24.0.2. - beehive-lab#486: Temurin for Windows added in the list of supported JDKs. - beehive-lab#525: Revert usage of String Templates in preparation for JDK 23. - beehive-lab#527: SPIR-V version parameter added. TornadoVM may run previous SPIR-V versions (e.g., ComputeAorta from Codeplay). - beehive-lab#513: LevelZero JNI Library updated to v0.1.4. Bug Fixes ~~~~~~~~~~~~~~~~~~ - beehive-lab#470: README documentation fixed. - beehive-lab#478: Fix the test names that are present in the white list. - beehive-lab#488: FP64 Kind for radian operations and the PTX backend fixed. - beehive-lab#493: Tests Whitelist for PTX backend fixed. - beehive-lab#502: Fix barrier type in the documentation regarding programmability of reductions. - beehive-lab#514: Installer script fixed. - beehive-lab#540: Fix issue with clean-up execution IDs function. - beehive-lab#541: Fix Data Accessors for the prebuilt API. - beehive-lab#543: Fix checkstyle condition and FP16 error message improved.
jjfumero
added a commit
to jjfumero/TornadoVM
that referenced
this pull request
Aug 30, 2024
Improvements ~~~~~~~~~~~~~~~~~~ - beehive-lab#468: Cleanup Abstract Metadata Class. - beehive-lab#473: Add maven plugin to build TornadoVM source for the releases. - beehive-lab#474: Refactor `<X>TornadoDevice` to place common methods in the `TornadoXPUInterface`. - beehive-lab#482: Help messages improved when an out-of-memory exception is raised. - beehive-lab#484: Double-type for the trigonometric functions added in the `TornadoMath` class. - beehive-lab#487: Prebuilt API simplified. - beehive-lab#494: Add test to trigger unsupported features related to direct use of Memory Segments. - beehive-lab#509: Add a quick pass configuration to skip the heavy tests during active development. - beehive-lab#532: Improve thread scheduler to support RISC-V Accelerators from Codeplay. - beehive-lab#533: Support for scalar values to be passed via lambda expressions as tasks. - beehive-lab#538: `README` file updated. - beehive-lab#539: Refactor core classes and add new API methods to pass compilation flags to the low-level driver compilers (OpenCL, PTX and Level Zero). - beehive-lab#542: Tagged LevelZero JNI and Beehive Toolkit dependencies added in the build and installer. Compatibility ~~~~~~~~~~~~~~~~~~ - beehive-lab#465: Support for JDK 22 and GraalVM 24.0.2. - beehive-lab#486: Temurin for Windows added in the list of supported JDKs. - beehive-lab#525: Revert usage of String Templates in preparation for JDK 23. - beehive-lab#527: SPIR-V version parameter added. TornadoVM may run previous SPIR-V versions (e.g., ComputeAorta from Codeplay). - beehive-lab#513: LevelZero JNI Library updated to v0.1.4. Bug Fixes ~~~~~~~~~~~~~~~~~~ - beehive-lab#470: README documentation fixed. - beehive-lab#478: Fix the test names that are present in the white list. - beehive-lab#488: FP64 Kind for radian operations and the PTX backend fixed. - beehive-lab#493: Tests Whitelist for PTX backend fixed. - beehive-lab#502: Fix barrier type in the documentation regarding programmability of reductions. - beehive-lab#514: Installer script fixed. - beehive-lab#540: Fix issue with clean-up execution IDs function. - beehive-lab#541: Fix Data Accessors for the prebuilt API. - beehive-lab#543: Fix checkstyle condition and FP16 error message improved. minor change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the data access (accessors) when having prebuilt tasks. It also removes the unused
OCLPrebuiltTask.This task is needed for the AERO EU project.
Problem description
Problem with accessors when having to copy in and out data in the prebuilt task mode.
Backend/s tested
Mark the backends affected by this PR.
OS tested
Mark the OS where this PR is tested.
Did you check on FPGAs?
If it is applicable, check your changes on FPGAs.
How to test the new patch?