Dependency pins #1041
Dependency pins #1041
Conversation
freakboy3742
force-pushed
the
dependency-pins
branch
2 times, most recently
from
7d95858
to
a485f63
Compare
freakboy3742
force-pushed
the
dependency-pins
branch
from
a485f63
to
3570485
Compare
setup.cfg
Outdated
| test = | ||
| pytest~=7.2 | ||
| pytest-tldr~=0.2 | ||
| pytest-cov~=4.0 | ||
| pytest == 7.2.0 | ||
| pytest-tldr == 0.2.5 | ||
| coverage[toml] == 7.0.4 |
There was a problem hiding this comment.
A development environment should probably have all the test tools installed, so Toga will merge[test] into [dev]as soon as the setuptools-scm PR is merged (beeware/toga#1675 (review)). Would it make sense to do the same for Briefcase?
There was a problem hiding this comment.
Yeah - the distinction is pretty narrow, so I guess that makes sense, if only for simplicity.
setup.cfg
Outdated
| install_requires = | ||
| pip >= 22 | ||
| setuptools >= 60 | ||
| wheel ~= 0.37 | ||
| cookiecutter ~= 2.1 | ||
| tomli ~= 2.0; python_version <= "3.10" | ||
| wheel >= 0.37 |
There was a problem hiding this comment.
We should leave a comment here explaining our pinning strategy: essentially the same text as the first post in this PR.
.github/workflows/ci.yml
Outdated
| @@ -93,7 +95,7 @@ jobs: | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install --upgrade setuptools | |||
| pip install setuptools_scm[toml]~=7.0 tox~=4.0 coverage[toml]~=7.0 | |||
| pip install $(ls dist/briefcase-*.whl)[dev,test] | |||
There was a problem hiding this comment.
There should be another "We don't actually want..." comment here.
Also, the difference between briefcase-*.whl here and *.whl below implies there might be some other wheels in dist, which is not actually the case. So I suggest we use briefcase-*.whl in both places.
Modify the usage of dependency pins:
Updating to the most recent version of Sphinx caused a version incompatibility with the RTD theme; since we've planning to move to Furo on Toga anyway, I figured this is as good a time as any to make that change.
Refs #1026.
Refs #1027.
Refs #1037.
PR Checklist: