-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency pins #1041
Dependency pins #1041
Changes from 6 commits
6eb04a3
ca08cf1
c4b1f07
ec7f12e
df100a9
3570485
fa78493
4bbe109
ff090ad
0134645
03dbb87
236dc57
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
The way dependency versions are specified has been modified to make Briefcase as accomodating as possible with end-user environments, but as stable as possible for development environments. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,36 +58,35 @@ package_dir = | |
install_requires = | ||
pip >= 22 | ||
setuptools >= 60 | ||
wheel ~= 0.37 | ||
cookiecutter ~= 2.1 | ||
tomli ~= 2.0; python_version <= "3.10" | ||
wheel >= 0.37 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should leave a comment here explaining our pinning strategy: essentially the same text as the first post in this PR. |
||
cookiecutter >= 2.1, < 3.0 | ||
tomli >= 2.0, < 3.0; python_version <= "3.10" | ||
importlib_metadata >= 4.4; python_version <= "3.9" | ||
requests ~= 2.28 | ||
GitPython ~= 3.1 | ||
dmgbuild ~= 1.6; sys_platform == "darwin" | ||
psutil ~= 5.9 | ||
rich ~= 12.6 | ||
platformdirs ~= 2.6 | ||
packaging ~= 22.0 | ||
tomli_w ~= 1.0 | ||
requests >= 2.28, < 3.0 | ||
GitPython >= 3.1, < 4.0 | ||
dmgbuild >= 1.6, < 2.0; sys_platform == "darwin" | ||
psutil >= 5.9, < 6.0 | ||
rich >= 12.6, < 14.0 | ||
platformdirs >= 2.6, < 3.0 | ||
packaging >= 22.0 | ||
tomli_w >= 1.0, < 2.0 | ||
|
||
[options.extras_require] | ||
dev = | ||
pre-commit~=2.20 | ||
setuptools_scm[toml] ~= 7.0 | ||
tox ~= 4.0 | ||
coverage[toml] ~= 7.0 | ||
pre-commit == 2.21.0 | ||
setuptools_scm[toml] == 7.0.5 | ||
tox == 4.0.1 | ||
test = | ||
pytest~=7.2 | ||
pytest-tldr~=0.2 | ||
pytest-cov~=4.0 | ||
pytest == 7.2.0 | ||
pytest-tldr == 0.2.5 | ||
coverage[toml] == 7.0.4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A development environment should probably have all the test tools installed, so Toga will merge There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah - the distinction is pretty narrow, so I guess that makes sense, if only for simplicity. |
||
docs = | ||
sphinx~=5.3 | ||
sphinxcontrib-spelling~=7.7 | ||
pyenchant~=3.2 | ||
sphinx-autobuild~=2021.3 | ||
sphinx_rtd_theme~=1.1 | ||
sphinx_tabs~=3.3 | ||
sphinx == 6.1.2 | ||
sphinxcontrib-spelling == 7.7.0 | ||
pyenchant == 3.2.2 | ||
sphinx-autobuild == 2021.3.14 | ||
furo == 2022.12.7 | ||
sphinx_tabs == 3.4.1 | ||
|
||
[options.packages.find] | ||
where = src | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be another "We don't actually want..." comment here.
Also, the difference between
briefcase-*.whl
here and*.whl
below implies there might be some other wheels indist
, which is not actually the case. So I suggest we usebriefcase-*.whl
in both places.