Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanups stemming from v0.3.11 release. #918

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

freakboy3742
Copy link
Member

The v0.3.11 release highlighted a couple of minor problems.

  1. The push instructions for the detached branch weren't quite right
  2. The gitignore file for the repo doesn't ignore logs directories.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@@ -34,3 +34,4 @@ venv*/
*.wp[ur]

tests/apps/verify-*/
logs/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would create a logs directory that isn't already ignored by one of the other rules? I tried running the unit tests, but they didn't do it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a manual build of the verify-toga app, to replicate one of the failures I saw during the release process. That generated a logs folder in tests/apps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the tests/apps subdirectories are already ignored by the line above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but the logs folder was generated in test/apps, because it was briefcase new that failed, rather than create etc. I guess we could narrow it to that specific known failure; but I figured we might as well have a blanked rule to avoid any stray logs folders.

@mhsmith mhsmith merged commit 4d7f4c9 into beeware:main Oct 17, 2022
@freakboy3742 freakboy3742 deleted the release-cleanups branch October 17, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants