Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups stemming from v0.3.11 release. #918

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Minor cleanups stemming from v0.3.11 release. #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1549824
Minor cleanups stemming from v0.3.11 release.
freakboy3742 Oct 14, 2022
f699253
Add changenote.
freakboy3742 Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ venv*/
*.wp[ur]

tests/apps/verify-*/
logs/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would create a logs directory that isn't already ignored by one of the other rules? I tried running the unit tests, but they didn't do it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a manual build of the verify-toga app, to replicate one of the failures I saw during the release process. That generated a logs folder in tests/apps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the tests/apps subdirectories are already ignored by the line above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but the logs folder was generated in test/apps, because it was briefcase new that failed, rather than create etc. I guess we could narrow it to that specific known failure; but I figured we might as well have a blanked rule to avoid any stray logs folders.

1 change: 1 addition & 0 deletions changes/918.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Minor problems with the release instructions were corrected.
2 changes: 1 addition & 1 deletion docs/how-to/internal/release.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ The procedure for cutting a new release is as follows:
4. Tag the release, and push the branch and tag upstream::

$ git tag v1.2.3
$ git push upstream main
$ git push upstream HEAD:main
$ git push upstream v1.2.3

5. Pushing the tag will start a workflow to create a draft release on GitHub.
Expand Down