Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's reach that 100% coverage! #1601

Closed
saroad2 opened this issue Oct 5, 2022 · 4 comments · Fixed by #2075
Closed

Let's reach that 100% coverage! #1601

saroad2 opened this issue Oct 5, 2022 · 4 comments · Fixed by #2075
Labels
enhancement New features, or improvements to existing features.

Comments

@saroad2
Copy link
Member

saroad2 commented Oct 5, 2022

Description
Lately we've managed to reach 100% coverage in briefcase (beeware/briefcase#887).

I think it is about time that we had 100% coverage for toga-core. At the time of opening this issue we stand on 93% coverage, which is pretty close! This will also remove the need for CodeCov.

100% coverage does not guarantee a bug-proof software, but it is an important step towards it.

@saroad2 saroad2 added the enhancement New features, or improvements to existing features. label Oct 5, 2022
@freakboy3742
Copy link
Member

Won't argue with the goal - 100% coverage is absolutely desirable.

However, if we're doing a big push on testing, I'd rather it wasn't a simple "run to the line" for coverage. As I've mentioned elsewhere, moving to PyTest natively is high on my todo list; along the way, I'd like to audit the tests to make sure we actually have good tests, not just coverage.

@bailaoshijiadao
Copy link

ExampleWebView routine accesses video web page, how to play it in full screen? Now you can only zoom in to the size of the application box

@mhsmith
Copy link
Member

mhsmith commented Jan 29, 2023

@bailaoshijiadao: Please create a separate issue for your question, and make sure to mention what OS you're running on.

@freakboy3742
Copy link
Member

For those tracking this issue: once #2075 (which includes #2058, #2020), #2065 (which includes #2017 and #2011), and #2029 (which includes #1903) are merged, we will have 100% coverage on core, android, cocoa, iOS, gtk, and winforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features, or improvements to existing features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants