Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for basic if/elif directives #405

Merged
merged 8 commits into from
Aug 23, 2021
Merged

Support for basic if/elif directives #405

merged 8 commits into from
Aug 23, 2021

Conversation

belav
Copy link
Owner

@belav belav commented Aug 17, 2021

closes #15

This handles the basics of formatting code in if directives and supplies a configuration option for more complex cases.
#404 will improve upon this initial work

@belav belav marked this pull request as draft August 18, 2021 03:24
@belav belav force-pushed the directives branch 3 times, most recently from 257cbc9 to 7d7d2e1 Compare August 21, 2021 15:18
@belav belav marked this pull request as ready for review August 21, 2021 15:32
@belav
Copy link
Owner Author

belav commented Aug 21, 2021

I tested this across the whole of https://github.com/belav/csharpier-repos and came across

There may be some other edge cases similar to #410, I haven't reviewed the actual formatting changes this makes except on the aspnetcore repo. But I think this can be deemed good enough for the first pass.

@belav belav merged commit d7ca975 into master Aug 23, 2021
@belav belav deleted the directives branch August 23, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code in IfDirective can't currently be formatted
1 participant