Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When #if starts with comma, it formats oddly #410

Closed
belav opened this issue Aug 21, 2021 · 1 comment
Closed

When #if starts with comma, it formats oddly #410

belav opened this issue Aug 21, 2021 · 1 comment
Labels

Comments

@belav
Copy link
Owner

belav commented Aug 21, 2021

In the given code, the , cannot be outside the #if. This leads to it being formatted like so.
Can we catch this and avoid breaking after the ,?

            [Option(
                "server_port"
#if DEBUG
                ,
                Default = 50052
#endif
            )]
@belav belav added this to the Beta milestone Sep 18, 2021
@belav belav removed this from the Beta milestone Sep 18, 2021
@belav belav added this to the 1.0.0 milestone Nov 21, 2022
@belav belav modified the milestones: 0.21.0, 0.22.0 Nov 28, 2022
@belav belav modified the milestones: 0.22.0, 0.23.0 Jan 4, 2023
belav added a commit that referenced this issue Feb 18, 2023
@belav
Copy link
Owner Author

belav commented Feb 25, 2023

This is super rare, and keeping the comma on the same line prior to the argument is a bit weird.

@belav belav closed this as completed Feb 25, 2023
@belav belav removed this from the 0.23.0 milestone Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant