deal with comments and #if's in argument lists #831
Conversation
There was a problem hiding this comment.
TBH, I'm not sure #831 should be a bug.
It's clear in this case that there's a comma that's in the #if.
But it doesn't really belong to the next parameter, and we've never absorbed that line break in any other circumstance.
IMHO I think the current behavior is better than putting the comma on the same line as the next argument. What do you think?
| arguments | ||
| is [ | ||
| { | ||
| Expression: ParenthesizedLambdaExpressionSyntax |
There was a problem hiding this comment.
oooh. Fancy list pattern match syntax 🏖️
|
I think I'm okay with just not doing this. I ran into it a couple times at work with our new multitargeting but it is super rare. I think there were ~30 instances of it across all of the code in https://github.com/belav/csharpier-repos. It's kinda ugly as is, but also weird with the preceding comma. So let's just not add extra code to deal with the super rare thing when the new formatting is debatable. |
closes #410