Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve problem examples #13

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Improve problem examples #13

merged 9 commits into from
Jan 30, 2024

Conversation

pvdbosch
Copy link
Contributor

@pvdbosch pvdbosch commented Sep 20, 2023 •
edited
Loading

solves #7

@pvdbosch pvdbosch marked this pull request as draft November 22, 2023 10:33
@pvdbosch
Copy link
Contributor Author

OpenAPI 2.0 changes still to do, after 3.0 changes have been reviewed

@pvdbosch pvdbosch marked this pull request as ready for review November 27, 2023 14:14
@pvdbosch pvdbosch requested a review from jpraet November 27, 2023 14:14
@pvdbosch
Copy link
Contributor Author

@jpraet , could you do a final review before merging?

@pvdbosch pvdbosch changed the title Improve problem examples #7 Improve problem examples Nov 27, 2023
@pvdbosch pvdbosch mentioned this pull request Nov 27, 2023
Closed
@pvdbosch
Copy link
Contributor Author

thanks for the review @jpraet , I'll wait for publication until next WG though, bc changes have to be aligned with possible feedback of the belgif/rest-guide#155 review

@pvdbosch
Copy link
Contributor Author

reviewed by WG, OK to merge

@pvdbosch pvdbosch merged commit 6a89c07 into master Jan 30, 2024
1 check passed
@pvdbosch pvdbosch deleted the feature/#7-improve-examples branch January 30, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraet jpraet jpraet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvdbosch @jpraet