Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve InputValidationProblem example #155

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

pvdbosch
Copy link
Contributor

"detail": "The input message is incorrect",
"instance": "urn:uuid:123456-1234-1235-4567489798",
"issues": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not that important, but in practice a combination of schemaValidation and non-schemaValidation issues within the same Bad Request problem is very unlikely, as the schemaValidation typically is done on an API Gateway, and the other validations are done on application level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's just an example to illustrate that it could be done.
There are cases that I know of where all types of validation or done by the backend (using generated classes with Jakarta Bean Validation). Clients shouldn't depend on order or grouping of validations.

@pvdbosch
Copy link
Contributor Author

reviewed by WG, OK to merge

@pvdbosch pvdbosch merged commit 33ed6b9 into master Jan 30, 2024
1 check passed
@pvdbosch pvdbosch deleted the feature/problem-example branch January 30, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants