Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bemhtml: Optimize quoting of data-bem attribute #250

Closed
veged opened this issue Sep 12, 2013 · 2 comments
Closed

bemhtml: Optimize quoting of data-bem attribute #250

veged opened this issue Sep 12, 2013 · 2 comments
Assignees
@aristov
Labels
v4
Milestone
4.0

Comments

@veged
Copy link
Member

veged commented Sep 12, 2013

We can use single quote and omit quoting of double quotes inside.
@narqo narqo added v2 and removed v1 labels Apr 12, 2014
@dfilatov dfilatov added v3 and removed v2 labels Apr 17, 2014
@veged veged added this to the 3.0 milestone Apr 24, 2014
@aristov aristov self-assigned this Nov 29, 2014
@aristov aristov mentioned this issue Nov 29, 2014
Merged
@tadatuta tadatuta mentioned this issue Jan 31, 2015
Open
@qfox qfox mentioned this issue Feb 3, 2015
Merged
@sameoldmadness
Copy link

@veged what's the motivation behind this changes?

is it about document size or source code readability?

@qfox qfox mentioned this issue Feb 8, 2015
Closed
aristov added a commit that referenced this issue Feb 25, 2015
@aristov
bemhtml: Optimize quoting of data-bem attribute (close #250)
9d8d439
aristov pushed a commit that referenced this issue Feb 25, 2015
Merge pull request #742 from /issues/250@v3
ae823f6 
bemhtml: Optimize quoting of data-bem attribute (close #250)
@aristov aristov closed this as completed Feb 25, 2015
@narqo
Copy link
Member

narqo commented Mar 19, 2015

is it about document size or source code readability?

@sameoldmadness both of them

@narqo narqo mentioned this issue Apr 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aristov aristov

Labels
v4
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
5 participants
@veged @dfilatov @narqo @sameoldmadness @aristov