Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use single quote instead of double in js params #980

Closed
sbmaxx opened this issue Apr 15, 2015 · 3 comments
Closed

Use single quote instead of double in js params #980

sbmaxx opened this issue Apr 15, 2015 · 3 comments
Labels
v2

Comments

@sbmaxx
Copy link

sbmaxx commented Apr 15, 2015

Это может немного уменьшить размер итогового HTML. В BH 4.0 @mishanga уже запили. Я попробовал на боевых проектах — 240 КБ превратилось в ~200 КБ.

Как побочный эффект — читать HTML становится приятней, глаз не спотыкается об "a: 'b'"
@sbmaxx sbmaxx mentioned this issue Apr 15, 2015
Merged
@mishanga
Copy link
Member

А после gzip заметна разница?

@sbmaxx
Copy link
Author

sbmaxx commented Apr 15, 2015

А после gzip заметна разница?

пара КБ буквально

narqo pushed a commit that referenced this issue Apr 16, 2015
@sbmaxx
Use single quot #980
7466353
narqo pushed a commit that referenced this issue Apr 16, 2015
Merge pull request #981 from sbmaxx/issues/980@v2
5efd217 
Use single quote #980
@narqo
Copy link
Member

narqo commented Apr 16, 2015

Same as #250 but for v2

@qfox qfox added the v2 label Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@narqo @sbmaxx @mishanga @qfox