Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ignore elem: '' #152

Closed
blond opened this issue Dec 16, 2015 · 0 comments
Closed

Should ignore elem: '' #152

blond opened this issue Dec 16, 2015 · 0 comments
Labels
semver: patch type: bug
Milestone
4.3.2

Comments

@blond
Copy link
Member

blond commented Dec 16, 2015

BEMJSON:

{
    block: 'b1',
    elem: 'e1'
}

BEMHTML:

block('b1').elem('e1').def()(function() {
    return applyCtx(this.extend(this.ctx, {
        block: 'b2',
        elem: ''
    }));
});

Actual:

<div class="b2__"></div>

Expected:

<div class="b2"></div>
@miripiruni miripiruni changed the title should ignore elem: '' Should ignore elem: '' Dec 22, 2015
indutny added a commit that referenced this issue Dec 22, 2015
@indutny
class-builder: elem === '' means no elem
6c427cc 
Fix: #152
@indutny indutny mentioned this issue Dec 22, 2015
Merged
miripiruni added a commit that referenced this issue Dec 25, 2015
@miripiruni
Merge pull request #159 from bem/fix/gh-152
2c024f6 
class-builder: `elem === ''` means no elem
@blond blond mentioned this issue Dec 30, 2015
Open
@miripiruni miripiruni modified the milestone: 4.3.2 Jan 13, 2016
miripiruni added a commit that referenced this issue Jan 19, 2016
@miripiruni
Port of 6c427cc (#152): class-builder: elem === '' means no elem
41604e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver: patch type: bug
Projects
None yet
Milestone
4.3.2
Development

No branches or pull requests
3 participants
@arikon @miripiruni @blond