Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class-builder: elem === '' means no elem #159

Merged
merged 1 commit into from
Dec 25, 2015
Merged

class-builder: elem === '' means no elem #159

merged 1 commit into from
Dec 25, 2015

Conversation

indutny
Copy link
Contributor

@indutny indutny commented Dec 22, 2015

Fix: #152

@qfox
Copy link
Member

qfox commented Dec 22, 2015

We just though about classBuilder as a https://github.com/bem/bem-naming clone. What you think about using .stringify in bem-xjst?

/cc @blond @miripiruni

@indutny
Copy link
Contributor Author

indutny commented Dec 22, 2015

I'm fine with this as long as benchmarks are happy with .stringify

@miripiruni
Copy link
Contributor

IMHO, I would like to merge PR as is. And open another one for modVal and elemModVal.

@qfox
Copy link
Member

qfox commented Dec 23, 2015

Yeah, agree.

@tadatuta
Copy link
Member

lgtm

qfox
qfox reviewed Dec 23, 2015
View reviewed changes
lib/bemxjst/class-builder.js
@@ -5,7 +5,7 @@ function ClassBuilder(options) {
exports.ClassBuilder = ClassBuilder;

ClassBuilder.prototype.build = function build(block, elem) {
if (elem === undefined)
if (!elem)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we can add here && elem !== 0 now or later~~?~~

@qfox
Copy link
Member

qfox commented Dec 23, 2015

Lgtm for now

miripiruni added a commit that referenced this pull request Dec 25, 2015
@miripiruni
Merge pull request #159 from bem/fix/gh-152
2c024f6 
class-builder: `elem === ''` means no elem
@miripiruni miripiruni merged commit 2c024f6 into master Dec 25, 2015
@miripiruni miripiruni mentioned this pull request Dec 25, 2015
Merged
@miripiruni miripiruni modified the milestone: 4.3.2 Jan 13, 2016
@miripiruni miripiruni deleted the fix/gh-152 branch March 14, 2016 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@indutny @qfox @miripiruni @tadatuta