Prevent deadlocks with replicas #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it isn't possible to gracefully cancel counting.
The pipe writer will deadlock if writing out the WAL segment fails for any reason.
hifi
force-pushed
the
for-upstream/deadlock-fixes
branch
from
5e9c94f to
2b4ec80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always close pipe reader when WriteWALSegment returns. If we don't, the writers can deadlock. We've had this happen when during shutdown replica Sync() gets called and it's being passed a canceled context.
Always use caller context for snapshotN as there is no guarantee the background context ever finishes. Haven't seen this causing problems in the wild but it has potential to lock up.