Fetch upstream #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been a couple of recent breaking changes so bumping the major version is required.
Add compat with older versions of devise
Bump version 1.1.5 -> 2.0.0
Fixes a minor typo in the README.md
Update two_factor_authenticatable.rb
OpenSSL::Cipher::Cipher has been deprecated in favor of OpenSSL::Cipher
Since now always includes , the test for passing the correct options to Encryptor should also include that option.
Check and use if newer bypass_sign_in method exists in devise
Low-res raster makes eyes bleed on retina displays 😎 [skip ci]
Switch badges to vector in README
Resource attribute otp_secret_key only needs a value if the user requires a TOTP value.
…change Doc change re otp_secret_key for version 1 to 2 upgrade
Fix test and deprecations
This is an attempt to play nice with other gems that might define methods that encrypt or decrypt data in a model.
Makes encrypt/decrypt method names unique:
dynamically generate path based on resource scope
Update README.md
Replace `render :nothing` with `head`
Some users enter the TOTP code with a space, which breaks authentication. This strips the space from the user-entered TOTP code and validates against it.
…p-code Strip Spaces from TOTP Code
Update README.md
Use correct module name
rotp upgrade
Update README.md
Update README.md
Add german translations
Fix README markdown formatting
Remove unused column `otp_confirmed`
Update README
Return JSON with 'redirect_to' when handle_failed_second_factor
Use ROTP::Base32.random instead of ROTP::Base32.random_base32 if available
This is a small change which will make users life so much easier.
Autofocus MFA code text field
Make current migration safe using index concurrently
Added license tag (MIT) to gemspec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
21 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.