Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the required Python versions to setup.py #19

Closed
leouieda opened this issue May 7, 2019 · 1 comment
Closed

Add the required Python versions to setup.py #19

leouieda opened this issue May 7, 2019 · 1 comment

Comments

@leouieda
Copy link
Contributor

leouieda commented May 7, 2019

It's best to specify the compatible Python versions in the setup.py using the python_requires argument. This let's pip et al know if your Python version is compatible and avoids installing broken packages.

It will probably be useful if adopting Pathlib which has some features that are 3.6+ only. I don't see many reasons to use 3.5 since most of the scientific stack has moved on to 3.6.

openjournals/joss-reviews#1425

@benmaier
Copy link
Owner

see also this comment in openjournals/joss-reviews#1425

Installation instructions: Instructions for installation work and are easy to follow, with the listed dependencies in setup.py being installed upon installation. However, these dependencies are in the documentation and do not appear on the Github readme and should be mentioned in both locations for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants