Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues with @nrwl/workspace 11+ #72

Merged
merged 16 commits into from
Jan 18, 2021

Conversation

pascalbayer
Copy link
Contributor

This PR fixes the error Cannot read property 'cyan' of undefined mentioned in #66 caused by @nrwl/workspace versions > 10, which currently makes nx-electron unusable with projects using nx versions > 10.
Basically it just bumps package dependencies of @nrwl/* to 11+ and fixes all other dependencies mentioned as vulnerabilities by npm audit.

@bennymeg
Copy link
Owner

Does this works for you without upgrading the angular-devkit packages to v11?

@pascalbayer
Copy link
Contributor Author

It does work, I've build the new version and already using it successfully in one of my projects. But I guess it makes sense to update it to the versions used internally by @nrwl/workspace to avoid any incompatible interfaces. Will push an update in a few minutes. Thanks for the feedback!

@pascalbayer
Copy link
Contributor Author

pascalbayer commented Jan 17, 2021

I've pushed a few more updates, including the usage of @nrwl/devkit instead of the outdated import { names, toFileName } from '@nrwl/workspace/src/utils/name-utils';

Just a few side notes:

  • Might make sense to include jshint to the devDependencies
  • Results from npm run test is: Tests: 45 failed, 22 passed, 67 total. However, this seems to be mainly related to a windows specific test setup that doesn't work on macOS, e.g. Path "[...]/nx-electron/jest/collection.json" does not exist. or TypeError: The "path" argument must be of type string. Received undefinedTypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined

I'll try to have a look to setup a platform independent testing setup in the next weeks if I have some time available.

@bennymeg
Copy link
Owner

Thank you for taking the time to create this pull request!

I will rebase it to a new branch (feature/v11) so it can be the base for v11. I will release it under v11.0.0-alpha.0 so it will be available for use for everyone.

Might make sense to include jshint to the devDependencies

No problems.

I'll try to have a look to setup a platform independent testing setup in the next weeks if I have some time available.

Tnx again!

@bennymeg bennymeg changed the base branch from master to feature/v11 January 18, 2021 18:14
@bennymeg bennymeg merged commit 3bf1651 into bennymeg:feature/v11 Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants