-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issues with @nrwl/workspace 11+ #72
Conversation
move workspace to dev dependency
Updates the `extends` property to target the default workspace filename: "tsconfig.base.json".
Fix(tsconfig): updates extends to nx default
…it dependencies in package-lock.json
Does this works for you without upgrading the |
It does work, I've build the new version and already using it successfully in one of my projects. But I guess it makes sense to update it to the versions used internally by @nrwl/workspace to avoid any incompatible interfaces. Will push an update in a few minutes. Thanks for the feedback! |
I've pushed a few more updates, including the usage of @nrwl/devkit instead of the outdated Just a few side notes:
I'll try to have a look to setup a platform independent testing setup in the next weeks if I have some time available. |
Thank you for taking the time to create this pull request! I will rebase it to a new branch (feature/v11) so it can be the base for v11. I will release it under v11.0.0-alpha.0 so it will be available for use for everyone.
No problems.
Tnx again! |
This PR fixes the error
Cannot read property 'cyan' of undefined
mentioned in #66 caused by @nrwl/workspace versions > 10, which currently makesnx-electron
unusable with projects using nx versions > 10.Basically it just bumps package dependencies of @nrwl/* to 11+ and fixes all other dependencies mentioned as vulnerabilities by npm audit.