Remove WIP comments from dashboard #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
@bkeepers As a longtime user of Delayed Job myself, I am humbled 😊
Thank you for your contribution! I have been wondering when the appropriate time is to remove the message... so thank you for pressing on that 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for all your work on good_job! I've been using it on a few projects lately and really like it. As the primary maintainer for delayed_job for many years, I have a special appreciation for the care and attention that you and the community have put into it.
I'm hoping to contribute more, but as my first pull request, I suggest removing the WIP messages from the dashboard. It looks like the one has been there for about two years now.