Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WIP comments from dashboard #566

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Remove WIP comments from dashboard #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3141406
Remove WIP comments from dashboard
bkeepers Apr 18, 2022
bff02b5
Merge branch 'main' into construction.gif
bensheldon Apr 18, 2022
9cdaf4b
Remove WIP comments from Russian translations
bensheldon Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions engine/app/views/good_job/shared/_announcement.erb
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions engine/app/views/good_job/shared/_navbar.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@
<li class="nav-item">
<%= link_to t(".processes"), processes_path, class: ["nav-link", ("active" if current_page?(processes_path))] %>
</li>
<li class="nav-item">
<div class="nav-link">
<span class="badge bg-secondary"><%= t(".coming_soon") %></span>
</div>
</li>
</ul>
<div class="nav-item pe-2">
<div class="form-check">
Expand Down
1 change: 0 additions & 1 deletion engine/app/views/layouts/good_job/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
<%= render "good_job/shared/navbar" %>

<div class="container-fluid">
<%= render "good_job/shared/announcement" %>
<%= render "good_job/shared/alert" %>

<%= yield %>
Expand Down
3 changes: 0 additions & 3 deletions engine/config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,10 @@ en:
other: "%{count} years"
good_job:
shared:
announcement:
work_in_progress_html: "🚧 GoodJob's dashboard is a work in progress. Please contribute ideas and code on <a href=\"https://github.com/bensheldon/good_job/issues\" target=\"_blank\" rel=\"nofollow noopener noreferrer\">Github</a>."
footer:
last_update_html: Last updated <time id="page-updated-at" datetime="%{time}">%{time}</time>
wording: Remember, you're doing a Good Job too!
navbar:
coming_soon: More views coming soon
cron_schedules: Cron Schedules
executions: All Executions
jobs: All Jobs
Expand Down
3 changes: 0 additions & 3 deletions engine/config/locales/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,10 @@ es:
other: "%{count} años"
good_job:
shared:
announcement:
work_in_progress_html: "🚧 GoodJob se encuentra en desarrollo. Por favor contribuya en <a href=\"https://github.com/bensheldon/good_job/issues\" target=\"_blank\" rel=\"nofollow noopener noreferrer\">GoodJob</a> con ideas y código."
footer:
last_update_html: Última actualización <time id="page-updated-at" datetime="%{time}">%{time}</time>
wording: "¡Recuerda, también tú estás haciendo un buen trabajo!"
navbar:
coming_soon: Próximamente más vistas
cron_schedules: Tareas Programadas
executions: Ejecuciones
jobs: Tareas
Expand Down
3 changes: 0 additions & 3 deletions engine/config/locales/ru.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,10 @@ ru:
other: "%{count} года"
good_job:
shared:
announcement:
work_in_progress_html: "🚧 GoodJob панель все еще в разработке. Пожалуйста расскажите нам о ваших идеях и наработках в <a href=\"https://github.com/bensheldon/good_job/issues\" target=\"_blank\" rel=\"nofollow noopener noreferrer\">Github</a>."
footer:
last_update_html: Последнее обновление <time id="page-updated-at" datetime="%{time}">%{time}</time>
wording: Запомни, ты делаешь Good Job тоже!
navbar:
coming_soon: Скоро будет больше секций
cron_schedules: Cron Расписания
executions: Все Исполнения
jobs: Все Задачи
Expand Down