Skip to content

Commit

Permalink
fix: server socket binding on Windows (#4685)
Browse files Browse the repository at this point in the history
Fixes #4684

Signed-off-by: Frost Ming <me@frostming.com>
  • Loading branch information
frostming authored May 6, 2024
1 parent 655df9e commit c1e2a94
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/_bentoml_impl/worker/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ def main(
"""
Start a HTTP server worker for given service.
"""
import socket

import psutil
import uvicorn

Expand Down Expand Up @@ -182,9 +184,8 @@ def main(

asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy()) # type: ignore

uvicorn.run(
config = uvicorn.Config(
app=asgi_app,
fd=fd,
backlog=backlog,
log_config=None,
workers=1,
Expand All @@ -195,6 +196,8 @@ def main(
server_header=False,
**uvicorn_extra_options,
)
socket = socket.socket(fileno=fd)
uvicorn.Server(config).run(sockets=[socket])


if __name__ == "__main__":
Expand Down

0 comments on commit c1e2a94

Please sign in to comment.