Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: server socket binding on Windows #4685

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: server socket binding on Windows #4685

merged 1 commit into from
May 6, 2024

Conversation

frostming
Copy link
Contributor

Fixes #4684

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Fixes #(issue)

Before submitting:

@frostming frostming requested a review from a team as a code owner April 23, 2024 01:18
@frostming frostming requested review from bojiang and removed request for a team April 23, 2024 01:19
@frostming
fix: server socket binding on Windows
361a4a9 
Fixes #4684

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming enabled auto-merge (squash) April 24, 2024 00:22
@frostming frostming merged commit c1e2a94 into main May 6, 2024
41 of 43 checks passed
@frostming frostming deleted the frostming/issue4684 branch May 6, 2024 05:48
@aarnphm aarnphm mentioned this pull request May 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojiang bojiang bojiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: module 'socket' has no attribute 'AF_UNIX'
2 participants
@frostming @bojiang