-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify inputs in documentation for ImageHandler #780
Conversation
Hello @akainth015, Thanks for updating this PR. There are currently no PEP 8 issues detected in this PR. Cheers! 🍻 Comment last updated at 2020-06-11 00:06:29 UTC |
Hi @akainth015 just to provide some context - there are active refactoring going on around the API handler code path, see the pinned issue #736 The ImageHandler in release 0.7.8 is actually the LegacyImageHandler in the master branch. In the current master branch's ImageHandler, we removed the capability to received multiple images at the same time, and plan to add a separate MultiImageHandler for that purpose. This makes it a lot easier for the user to run inference jobs from CLI with image files as input. In the new ImageHandler, when posting form-data request, the "image_file" name in the swagger input definition actually can be anything, since the handler is expecting only one image file uploaded per request. This behavior is similar in the LegacyImageHandler, when it is used for handling single image input. |
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
==========================================
+ Coverage 55.33% 55.34% +0.01%
==========================================
Files 108 108
Lines 8158 8143 -15
==========================================
- Hits 4514 4507 -7
+ Misses 3644 3636 -8
Continue to review full report at Codecov.
|
Ah, alright. That makes a lot of sense! Do you think I should just close this pull request, or update the documentation for |
@akainth015 I think it's probably better to close the PR for now and wait until the API handler refactoring work is merged since it probably will change things around both files. @bojiang is currently working on that and expect the initial PR to come out in a day or two. |
Description
Just the title, specify the MIME types that the
ImageHandler
accepts so that they don't have to be found in Swagger.Motivation and Context
This change helps developers discover the features in
ImageHandler
without having to set it up, build their service, open it in Swagger, and then browse the available MIME types.How Has This Been Tested?
Rebuilt the documentation and verified that the changes show up correctly.
Types of changes
Components (if applicable)
Checklist:
./dev/format.sh
and./dev/lint.sh
script have passed(instructions).