Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS/BUILD] Update watch script for Linux #781

Merged
merged 3 commits into from
Jun 11, 2020

Conversation

akainth015
Copy link
Contributor

Description

Run the watch script on Linux

Motivation and Context

Better support for more development environments

How Has This Been Tested?

Used it to do the previous pull request #780

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation
  • Test, CI, or build
  • None

Components (if applicable)

  • BentoService (model packaging, dependency management, handler definition)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, logging, metrics, tracing, benchmark, OpenAPI)
  • YataiService (model management, deployment automation)
  • Documentation

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change in bentoml/gallery example notebooks
  • I have sent a pull request to bentoml/gallery to make that change

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #781 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
+ Coverage   55.34%   55.53%   +0.18%     
==========================================
  Files         108      108              
  Lines        8143     8144       +1     
==========================================
+ Hits         4507     4523      +16     
+ Misses       3636     3621      -15     
Impacted Files Coverage Δ
bentoml/artifact/__init__.py 100.00% <0.00%> (ø)
bentoml/artifact/spacy_model_artifact.py 40.54% <0.00%> (+40.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea9848...4422690. Read the comment docs.

@parano
Copy link
Member

parano commented Jun 11, 2020

@akainth015 do you mind also add some quick notes about this to the development.md? It currently says watch.sh is MacOS only. It would be nice to also include links to how to install inotifywait. Thanks!

@akainth015
Copy link
Contributor Author

@parano thanks, I hadn't noticed that it was in DEVELOPMENT.md. Since xdg-open should be there in most distros I just added instructions for inotifywait.

@parano parano changed the title Update watch script for Linux [DOCS/BUILD] Update watch script for Linux Jun 11, 2020
@parano parano merged commit f9da611 into bentoml:master Jun 11, 2020
@akainth015 akainth015 deleted the linux-watch branch July 27, 2020 20:56
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
* Update watch script for Linux

* Update DEVELOPMENT.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants