Remap Exif-JS Usage Until Updated

[ammuench]

The most current version of exif-js is 2.3.0 and was updated years ago. However, the version was uploaded with the following bug: exif-js/exif-js#214

As a result, ng2-img-max also will hit that issue when uploading some files. I have fixed this issue in my local by forking the current state of exif-js and adding it to my package manifest as a git repo instead, so that the "undefined n" issue is fixed.

ng2-img-max should either make the same decision and commit the changes or look for an alternative exif library, as it appears the issue will not be fixed in exif-js any time soon (the last update was over a year ago)

[matteobucci]

Hi @ammuench, I'm facing the same issue and have reached the same conclusions about the problem. Could you please explain which edit you have made in order to it working? Thanks

[Methodician]

So you had to fork the library just to get around this bug? Has anyone found a good EXIF reader library that is kept up to date? All I use this for is to catch orientation issues in my app, and it is such a slog to work through this library...

[ammuench]

Yeah, I'm happy to publish the fixes I made once I figure out the licensing in order to unblock people if it would be helpful @Methodician

[bergben]

@ammuench If you are interested you may also update ng2-img-max. This library would greatly benefit from an active maintainer. Please let me know if you would be so kind to help out with this and I'd transfer it to you

There is an open PR for this too: #44

[ammuench]

I don't know how involved I can be, but if you'd like to pass it over to me I'd be happy to go through the current PRs and clean up what I can! Considering my current project buses a modified version I can at least get our changes into the main stream

…

On Thu, Feb 20, 2020, 2:26 AM Benedikt Berger ***@***.***> wrote: @ammuench <https://github.com/ammuench> If you are interested you may also update ng2-img-max. This library would greatly benefit from an active maintainer. Please let me know if you would be so kind to help out with this and I'd transfer it to you — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#41?email_source=notifications&email_token=AAQATSSNEEXNXI4PNN5FEU3RDY5CBA5CNFSM4IWYB47KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEML2YXY#issuecomment-588754015>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQATSVZ5RNCMBI5MDEYQ2DRDY5CBANCNFSM4IWYB47A> .

[ammuench]

@bergben Feel free to reach out to me via email if you'd like to discuss further

[MikeKovarik]

Hello. exif-js seems to be dead since it hasn't been updated in two years. Because of that I have been developing my own library exifr where performance was the main focus. I'd be happy to do a pull request :)

[bergben]

@MikeKovarik looks promising! If you would be so kind to open a PR then I'm happy to merge it in and release a new version on npm :)

[MikeKovarik]

@bergben awesome! :) So here it is.

I discovered ng2-img-max is dependent on ng2-pica which also uses exif-js so I thought it'd be better to start there

PR for ng2-pica: bergben/ng2-pica#13
PR for ng2-img-max: #46 but i suppose here we should wait for the ng2-pica to be updated first and then raise the version here.

Thank you

[bergben]

Merged both PRs, updated ng2-pica version in ng2-img-max

released on npm

• pica 1.3.0
• ng2-img-max 2.2.1

Thanks @MikeKovarik

[bergben]

Please use ng2-img-max 2.2.1, 2.2.0 is broken.