replaced exif-js with exifr #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MikeKovarik hi I get this error ReferenceError: TextDecoder is not defined after the update to exifr. |
|
Hi. what browser are you using? |
|
Ok. so i noticed this module supports IE10+. I mistakenly assumed it supports only evergreens, but i was looking at ng2-pica where there's no mention of IE in the readme. The fix is fortunately faily simple. All that's needed is simply replace plain import import * as exifr from 'exifr';with legacy one (it includes shim for TextDecoder I'll make PRs today |
This was referenced Mar 20, 2020
|
released 2.2.4 with new PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in response to #41