Save vtx_table lua file. #1759
Merged
Save vtx_table lua file. #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozenskys
force-pushed
the
save_vtx_table_lua
branch
2 times, most recently
from
0febf39 to
1683d39
Compare
frozenskys
force-pushed
the
save_vtx_table_lua
branch
from
8e565e8 to
b05c310
Compare
mikeller
reviewed
Oct 27, 2019
| @@ -5225,6 +5225,10 @@ | |||
| "message": "Save to file", | |||
| "description": "Save to file button in the VTX tab" | |||
| }, | |||
| "vtxButtonSaveLua": { | |||
| "message": "Save Lua Script", | |||
There was a problem hiding this comment.
I think for this it would be helpful to add a tooltip to this button that provided a short explanation of how users can use this to get their custom VTX table supported in the lua scripts.
There was a problem hiding this comment.
Great idea... I'll also look at updating the lua readme.
mikeller
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches up with the lua script changes in betaflight/betaflight-tx-lua-scripts#264
Probably needs some tidying up, suggestions welcome. :)