Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTX tables #264

Merged
merged 3 commits into from
Oct 27, 2019
Merged

VTX tables #264

merged 3 commits into from
Oct 27, 2019

Conversation

frozenskys
Copy link
Contributor

Setting to draft, as this is still a work in progress and currently untested (apart from the fact it compiles and starts without error on the sim)

@frozenskys
Copy link
Contributor Author

Trying to implement the vtx tables as discussed in #243

Comment on lines +10 to +11
deviceTable = { [1]="6705", [3]="SA", [4]="Tramp", [255]="None" }
pitModeTable = { [0]="OFF", "ON" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these need to be part of the 'defaults'. But then, on the other hand, it makes sense to have them in one centralised file instead of having them included the file for each TX type - we currently do too much of this anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeller I already have a plan to refactor the scripts into unified logic, and just load the "layout" for the screens from files based on the screen dimensions, rather than the radio type, as all else seems to be the same - which should make maintenance much easier. I also noticed that the rx.lua script is missing from the X7 folder - do you know if this is deliberate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re missing rx.lua file, I suspect that this is just a consequence of the copy / paste way that multi TX support is done at the moment.

@frozenskys
Copy link
Contributor Author

@mikeller about the powerlevels - what do we need to send over msp back to the FC as I think with the vtx tables this has changed?

  1. 0,1,2,3 (power index?)
  2. 14, 20, 30 (power dBm ?)
  3. 0,25,100 (power mW)
  4. something else?

@mikeller
Copy link
Member

@frozenskys: The power index - the flight controller then uses the VTX table to translate this into the value to send to the VTX.

@frozenskys frozenskys marked this pull request as ready for review October 23, 2019 20:31
@mikeller mikeller added this to the 1.5 milestone Oct 27, 2019
@mikeller mikeller merged commit 6b61595 into betaflight:master Oct 27, 2019
@frozenskys frozenskys deleted the vtx_tables branch October 27, 2019 10:58
@mikeller mikeller mentioned this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants