-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTX tables #264
VTX tables #264
Conversation
Trying to implement the vtx tables as discussed in #243 |
deviceTable = { [1]="6705", [3]="SA", [4]="Tramp", [255]="None" } | ||
pitModeTable = { [0]="OFF", "ON" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if these need to be part of the 'defaults'. But then, on the other hand, it makes sense to have them in one centralised file instead of having them included the file for each TX type - we currently do too much of this anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeller I already have a plan to refactor the scripts into unified logic, and just load the "layout" for the screens from files based on the screen dimensions, rather than the radio type, as all else seems to be the same - which should make maintenance much easier. I also noticed that the rx.lua script is missing from the X7 folder - do you know if this is deliberate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re missing rx.lua file, I suspect that this is just a consequence of the copy / paste way that multi TX support is done at the moment.
@mikeller about the powerlevels - what do we need to send over msp back to the FC as I think with the vtx tables this has changed?
|
@frozenskys: The power index - the flight controller then uses the VTX table to translate this into the value to send to the VTX. |
29c29e0
to
fd93b50
Compare
fd93b50
to
3030559
Compare
Setting to draft, as this is still a work in progress and currently untested (apart from the fact it compiles and starts without error on the sim)