IT-5528 | Fixes after upstream update #10
Conversation
| @@ -1,6 +1,6 @@ | |||
| import InputView from '@ckeditor/ckeditor5-ui/src/input/inputview'; | |||
| import { View } from 'ckeditor5/src/ui'; | |||
There was a problem hiding this comment.
FIx import, after changing View to InputView in 2de8f65
InputView automatically emits input event which is handled in
ckeditor5-math/src/ui/mathliveview.js
Line 14 in 9bb53dd
| @@ -166,7 +184,7 @@ export default class MainFormView extends View { | |||
| const t = this.locale.t; | |||
|
|
|||
| // Create equation input | |||
| const mathInput = new LabeledFieldView( this.locale, createLabeledInputText ); | |||
| const mathInput = new LabeledFieldView( this.locale, createLabeledTextarea ); | |||
There was a problem hiding this comment.
bring back textarea that we lost when resolving conflicts: https://github.com/bethinkpl/ckeditor5-math/pull/9/files#diff-2efc953309779ec3dc248aac8e35081f80c768c7ad0c8ef8bdaea55cd044e156L179
| @@ -36,12 +36,12 @@ | |||
| "@ckeditor/ckeditor5-theme-lark": "40.1.0", | |||
| "@ckeditor/ckeditor5-upload": "40.1.0", | |||
| "eslint": "^7.32.0", | |||
| "eslint-config-ckeditor5": "^5.1.1", | |||
| "eslint-config-ckeditor5": "^5.1.2", | |||
There was a problem hiding this comment.
It was a part of isaul32@fffb69b but not 41f075f
There was a problem hiding this comment.
Without it, I was getting error about node 20 not being supported.
| ...this.template.attributes, | ||
| style: { | ||
| resize: 'both', | ||
| overflow: 'auto' |
There was a problem hiding this comment.
We don't set it now, is that correct? I don't really see the difference with or without it.
@pioziol123 do you remember why you've added it in 2c275e7?
There was a problem hiding this comment.
Hardly, I think it was something with virtual keyboard 🤷🏻♂️
There was a problem hiding this comment.
Nothing pops out for me after playing with the keyboard. Maybe it's something visible only in the app? @kvas-damian how about adding it for safety? Or do you prefer to put more time into searching what is it for?
There was a problem hiding this comment.
ok, will add it for safety. I've seen enough strange things with styles in this module, so better safe than sorry ;)
No description provided.