IT-5528 | Fixes after upstream update #10
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,14 @@ | ||
| import { icons } from 'ckeditor5/src/core'; | ||
| import { | ||
| ButtonView, | ||
| createLabeledTextarea, | ||
| FocusCycler, | ||
| LabeledFieldView, | ||
| LabelView, | ||
| submitHandler, | ||
| SwitchButtonView, | ||
| View, | ||
| ViewCollection | ||
| } from 'ckeditor5/src/ui'; | ||
| import { FocusTracker, KeystrokeHandler } from 'ckeditor5/src/utils'; | ||
| import { extractDelimiters, hasDelimiters } from '../utils'; | ||
|
|
@@ -166,8 +173,9 @@ export default class MainFormView extends View { | |
| const t = this.locale.t; | ||
|
|
||
| // Create equation input | ||
| const mathInput = new LabeledFieldView( this.locale, createLabeledTextarea ); | ||
|
There was a problem hiding this comment. bring back textarea that we lost when resolving conflicts: https://github.com/bethinkpl/ckeditor5-math/pull/9/files#diff-2efc953309779ec3dc248aac8e35081f80c768c7ad0c8ef8bdaea55cd044e156L179 |
||
| const fieldView = mathInput.fieldView; | ||
| fieldView.set( 'resize', 'both' ); | ||
| mathInput.infoText = t( 'Insert equation in TeX format.' ); | ||
|
|
||
| const onInput = () => { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import { View } from 'ckeditor5/src/ui'; | ||
|
There was a problem hiding this comment. FIx import, after changing
ckeditor5-math/src/ui/mathliveview.js Line 14 in 9bb53dd |
||
|
|
||
| export default class MathLiveView extends View { | ||
| constructor( locale, { options, attributes } ) { | ||
| super( locale ); | ||
| this._options = options; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ | |
| padding: 16px; | ||
|
|
||
| & .ck-input { | ||
| overflow: auto; | ||
| width: 100%; | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a part of isaul32@fffb69b but not 41f075f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without it, I was getting error about node 20 not being supported.