-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start 0.5 -> 0.6 Migration guide #185
Conversation
This PR is pretty noisy because it contains a number of other commits in its history; can you rebase? |
I actually rebased the PR onto Master to get the changes from #191, as I locally use Zola 0.14. |
### QuerySet declare "QueryState" instead of "Query" | ||
<!-- Adapt for ParamSet instead, if https://github.com/bevyengine/bevy/pull/2765 is merged --> | ||
|
||
Due to the [System Param Lifetime Split](#system-param-lifetime-split), {{rust_type(type="struct" crate="bevy_ecs" mod="system" name="QuerySet" version="0.6.0" no_mod=true plural=true)}} now need to specify their Queries with {{rust_type(type="struct" crate="bevy_ecs" mod="query" version="0.6.0" name="QuerySet" no_mod=true)}} instead of {{rust_type(type="struct" crate="bevy_ecs" mod="system" version="0.6.0" name="Query" no_mod=true)}}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo here it says:
Due to the System Param Lifetime Split, QuerySets now need to specify their Queries with QuerySet instead of Query .
It should say:
"... Queries with QueryState instead of Query."
My rough notes from the migration process so far for a 2d game.
edit: Checking these off when PRs are opened covering them |
For 3d, For 2d, yeah, sprites and UI are always assumed transparent. Which makes sense, because they practically always are. |
. mp3 is no more the default , ogg now is. |
Things I've noticed so far that hasn't been listed
For example
This affects all the different dimensions of the math vectors (i.e., Vec2, Vec3 and Vec4).
|
In glam 15,
In these cases, it's likely that the user was shooting themselves in the foot, because these impls were only comparing the vectors one-dimensionally. |
I think the |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
This PR starts a new Migration guide, with the following changes:
.system()
from [Merged by Bors] - Optional.system
bevy#2398, [Merged by Bors] - Optional.system()
, part 2 bevy#2403, [Merged by Bors] - Optional.system()
, part 3 bevy#2422 and [Merged by Bors] - Optional.system()
, part 4 (run criteria) bevy#2431,#[derive(Component)]
on all component structs bevy#2254Input
bevy#1781Ignored Changes:
S-Needs-Migration-Guide
Label, but the feature was already broken in0.5
and originally fixed in [Merged by Bors] - AddingWorldQuery
forWithBundle
bevy#2024ScheduleRunnerPlugin
bevy#2606: The change is small and the old.add_plugin(bevy::app::ScheduleRunnerPlugin {})
syntax still compiles in0.6
.I started this, before noticing that #134 already exists.