Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Merge AppBuilder into App #2531

Closed
wants to merge 1 commit into from

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Jul 24, 2021

This is extracted out of eb8f973 and includes some additional changes to remove all references to AppBuilder and fix examples that still used App::build() instead of App::new(). In addition I didn't extract the sub app feature as it isn't ready yet.

You can use git diff --diff-filter=M eb8f973646476b4a4926ba644a77e2b3a5772159 to find all differences in this PR. The --diff-filtered=M filters all files added in the original commit but not in this commit away.

Co-Authored-By: Carter Anderson mcanders1@gmail.com

@bjorn3
Copy link
Contributor Author

bjorn3 commented Jul 24, 2021

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jul 24, 2021
@bjorn3 bjorn3 added A-App Bevy apps and plugins C-Feature A new feature, making something new possible and removed S-Needs-Triage This issue needs to be labelled labels Jul 24, 2021
This is extracted out of eb8f973 and
includes some additional changes to remove all references to AppBuilder
and fix examples that still used App::build() instead of App::new(). In
addition I didn't extract the sub app feature as it isn't ready yet.

You can use `git diff --diff-filter=M eb8f973`
to find all differences in this PR. The `--diff-filtered=M` filters all
files added in the original commit but not in this commit away.

Co-Authored-By: Carter Anderson <mcanders1@gmail.com>
@cart
Copy link
Member

cart commented Jul 27, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jul 27, 2021
This is extracted out of eb8f973 and includes some additional changes to remove all references to AppBuilder and fix examples that still used App::build() instead of App::new(). In addition I didn't extract the sub app feature as it isn't ready yet.

You can use `git diff --diff-filter=M eb8f973` to find all differences in this PR. The `--diff-filtered=M` filters all files added in the original commit but not in this commit away.

Co-Authored-By: Carter Anderson <mcanders1@gmail.com>
@bors bors bot changed the title Merge AppBuilder into App [Merged by Bors] - Merge AppBuilder into App Jul 27, 2021
@bors bors bot closed this Jul 27, 2021
@bjorn3 bjorn3 deleted the merge_app_builder branch July 27, 2021 20:41
weswigham added a commit to weswigham/bevy_kira_audio that referenced this pull request Oct 24, 2021
Per [this PR](bevyengine/bevy#2531). Since the `Cargo.toml` points at bevy 0.5.0 and not `{ git = "https://github.com/bevyengine/bevy", branch = "main" }`, I don't think this'll build yet, but this is all I had to change to get this building locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-App Bevy apps and plugins C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants