[Merged by Bors] - Merge AppBuilder into App #2531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
added
A-App
This is extracted out of eb8f973 and includes some additional changes to remove all references to AppBuilder and fix examples that still used App::build() instead of App::new(). In addition I didn't extract the sub app feature as it isn't ready yet. You can use `git diff --diff-filter=M eb8f973` to find all differences in this PR. The `--diff-filtered=M` filters all files added in the original commit but not in this commit away. Co-Authored-By: Carter Anderson <mcanders1@gmail.com>
bjorn3
force-pushed
the
merge_app_builder
branch
from
287e030
to
b256c0e
Compare
64 tasks
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
This is extracted out of eb8f973 and includes some additional changes to remove all references to AppBuilder and fix examples that still used App::build() instead of App::new(). In addition I didn't extract the sub app feature as it isn't ready yet. You can use `git diff --diff-filter=M eb8f973` to find all differences in this PR. The `--diff-filtered=M` filters all files added in the original commit but not in this commit away. Co-Authored-By: Carter Anderson <mcanders1@gmail.com>
bors
bot
changed the title
weswigham
added a commit
to weswigham/bevy_kira_audio
that referenced
this pull request
Oct 24, 2021
Per [this PR](bevyengine/bevy#2531). Since the `Cargo.toml` points at bevy 0.5.0 and not `{ git = "https://github.com/bevyengine/bevy", branch = "main" }`, I don't think this'll build yet, but this is all I had to change to get this building locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted out of eb8f973 and includes some additional changes to remove all references to AppBuilder and fix examples that still used App::build() instead of App::new(). In addition I didn't extract the sub app feature as it isn't ready yet.
You can use
git diff --diff-filter=M eb8f973646476b4a4926ba644a77e2b3a5772159to find all differences in this PR. The--diff-filtered=Mfilters all files added in the original commit but not in this commit away.Co-Authored-By: Carter Anderson mcanders1@gmail.com