-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy examples on website in wasm #225
Conversation
This is a really nice idea, i like it! |
Great work as always! Some random thoughts:
|
Hm...you're right, it will be a problem on mobile. I guess a good compromise would be to put a link on the |
Added! The example page is very lacking in styling, but that's not my strong suit...
Yup, I wanted to have something deployed as soon as possible to check deploy is working, and to be able to point lots of people/os/browsers at it to check compatibility. But it doesn't need to be linked somewhere for that, plus an "official" link would be better with the 0.6 release post |
Happy to give that a go once we merge this :)
Makes sense! |
The |
It's how the two existing scripts, Suggestions are welcome though, you can see from the number of commits to get the syntax right that I'm not really a fan of shell scripts 👍 |
Looks like a good baseline to me. Lets get this merged! |
Looks really nice, great work 😀 The
I am on Firefox 95.0.2 (64-Bit) on Windows 10 with AMD Radeon RX570. All other examples, |
That's due to gfx-rs/naga#1616 which makes it crash on everything except firefox on macOS...
Yup! |
I think we've ironed out enough of the kinks to justify making the examples page more prominent. We've been sitting on a lot of value here for awhile 😄 For posterity: big thanks to @mockersf for putting together this feature in #225 and @doup for adding loading feedback in #355 and a bunch of other visual improvements.
Build examples in wasm and deploy them under https://bevyengine.org/examples
It adds:
Notes