Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add Examples to nav and add "intro" text #392

Closed
wants to merge 1 commit into from

Conversation

cart
Copy link
Member

@cart cart commented Jul 8, 2022

I think we've ironed out enough of the kinks to justify making the examples page more prominent. We've been sitting on a lot of value here for awhile 😄

For posterity: big thanks to @mockersf for putting together this feature in #225 and @doup for adding loading feedback in #355 and a bunch of other visual improvements.

@cart cart requested a review from mockersf July 8, 2022 20:46
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to keep it in the learn section if it's already in the header, but other than that I tried it locally and it looks good.

@alice-i-cecile
Copy link
Member

I'm on board with this choice :)

@cart
Copy link
Member Author

cart commented Jul 8, 2022

bors r+

@cart
Copy link
Member Author

cart commented Jul 8, 2022

Not sure if we want to keep it in the learn section if it's already in the header, but other than that I tried it locally and it looks good.

I think we probably do as we don't want people to accidentally miss the examples when looking for learning material.

bors bot pushed a commit that referenced this pull request Jul 8, 2022
I think we've ironed out enough of the kinks to justify making the examples page more prominent. We've been sitting on a lot of value here for awhile 😄 

For posterity: big thanks to @mockersf for putting together this feature in #225 and @doup for adding loading feedback in #355 and a bunch of other visual improvements.
@bors
Copy link

bors bot commented Jul 8, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Add Examples to nav and add "intro" text [Merged by Bors] - Add Examples to nav and add "intro" text Jul 8, 2022
@bors bors bot closed this Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants