Skip to content

Commit

Permalink
Update tracing-tracy requirement from 0.10.4 to 0.11.0 and tracy-cli…
Browse files Browse the repository at this point in the history
…ent requirement from 0.16.4 to 0.17.0 (#11678)

# Objective

- Update `tracing-tracy`.
- Closes #11598.

## Solution

- Bump `tracing-tracy` to 0.11.0 and `tracy-client` alongside it to
0.17.0 to avoid duplicating that dependency in the deps tree.
- `TracyLayer` is now configurable on creation, so use the default
config.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
Kanabenki and dependabot[bot] authored Feb 3, 2024
1 parent 694c06f commit 4e9590a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions crates/bevy_log/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ tracing-error = { version = "0.2.0", optional = true }

# Tracy dependency compatibility table:
# https://github.com/nagisa/rust_tracy_client
tracing-tracy = { version = "0.10.4", optional = true }
tracy-client = { version = "0.16.4", optional = true }
tracing-tracy = { version = "0.11.0", optional = true }
tracy-client = { version = "0.17.0", optional = true }

[target.'cfg(target_os = "android")'.dependencies]
android_log-sys = "0.3.0"
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_log/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ impl Plugin for LogPlugin {
};

#[cfg(feature = "tracing-tracy")]
let tracy_layer = tracing_tracy::TracyLayer::new();
let tracy_layer = tracing_tracy::TracyLayer::default();

let fmt_layer = tracing_subscriber::fmt::Layer::default().with_writer(std::io::stderr);

Expand Down

1 comment on commit 4e9590a

@pcwalton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit broke stable Tracy, requiring all users to now compile Tracy from source where they didn't need to before. Do we really want to do that?

Please sign in to comment.