Skip to content

Commit

Permalink
Remove all usages of unsafe in mikktspace, and add regression tests
Browse files Browse the repository at this point in the history
  • Loading branch information
LaylBongers committed Jul 16, 2023
1 parent a30da00 commit 4eb43c6
Show file tree
Hide file tree
Showing 25 changed files with 10,912 additions and 2,706 deletions.
12 changes: 10 additions & 2 deletions crates/bevy_mikktspace/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
name = "bevy_mikktspace"
version = "0.12.0-dev"
edition = "2021"
authors = ["Benjamin Wasty <benny.wasty@gmail.com>", "David Harvey-Macaulay <alteous@outlook.com>", "Layl Bongers <LaylConway@users.noreply.github.com>"]
authors = [
"Benjamin Wasty <benny.wasty@gmail.com>",
"David Harvey-Macaulay <alteous@outlook.com>",
"Layl Bongers <LaylBongers@users.noreply.github.com>",
]
description = "Mikkelsen tangent space algorithm"
documentation = "https://docs.rs/bevy"
homepage = "https://bevyengine.org"
Expand All @@ -12,6 +16,10 @@ keywords = ["bevy", "3D", "graphics", "algorithm", "tangent"]

[dependencies]
glam = "0.24"
bitflags = "2.3"

[dev-dependencies]
bytemuck = { version = "1.13", features = ["derive"] }

[[example]]
name = "generate"
name = "cube_tangents"
4 changes: 2 additions & 2 deletions crates/bevy_mikktspace/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ Requires at least Rust 1.52.1.

## Examples

### generate
### cube_tangents

Demonstrates generating tangents for a cube with 4 triangular faces per side.

```sh
cargo run --example generate
cargo run --example cube_tangents
```

## License agreement
Expand Down
Binary file added crates/bevy_mikktspace/data/cube.bin
Binary file not shown.
File renamed without changes.
Binary file added crates/bevy_mikktspace/data/suzanne_bad.bin
Binary file not shown.
Loading

0 comments on commit 4eb43c6

Please sign in to comment.