do not set hit test unconditionally on window creation (#7996)

bevyengine · Mar 13, 2023 · 71b1b35 · 71b1b35
1 parent 6bfc09f
commit 71b1b35
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/crates/bevy_winit/src/winit_windows.rs b/crates/bevy_winit/src/winit_windows.rs
@@ -166,11 +166,16 @@ impl WinitWindows {
         }
 
         winit_window.set_cursor_visible(window.cursor.visible);
-        if let Err(err) = winit_window.set_cursor_hittest(window.cursor.hit_test) {
-            warn!(
-                "Could not set cursor hit test for window {:?}: {:?}",
-                window.title, err
-            );
+
+        // Do not set the cursor hittest on window creation if it's false, as it will always fail on some
+        // platforms and log an unfixable warning.
+        if !window.cursor.hit_test {
+            if let Err(err) = winit_window.set_cursor_hittest(window.cursor.hit_test) {
+                warn!(
+                    "Could not set cursor hit test for window {:?}: {:?}",
+                    window.title, err
+                );
+            }
         }
 
         self.entity_to_winit.insert(entity, winit_window.id());