Skip to content

Commit

Permalink
Double the capacity when BlobVec is full
Browse files Browse the repository at this point in the history
  • Loading branch information
garychia committed Jan 1, 2024
1 parent 71adb77 commit a625547
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions crates/bevy_ecs/src/storage/blob_vec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,9 @@ impl BlobVec {
/// The `value` must match the [`layout`](`BlobVec::layout`) of the elements in the [`BlobVec`].
#[inline]
pub unsafe fn push(&mut self, value: OwningPtr<'_>) {
self.reserve_exact(1);
if self.len == self.capacity {
self.reserve_exact(self.capacity.max(1));
}
let index = self.len;
self.len += 1;
self.initialize_unchecked(index, value);
Expand Down Expand Up @@ -519,7 +521,7 @@ mod tests {
}

assert_eq!(blob_vec.len(), 1_000);
assert_eq!(blob_vec.capacity(), 1_000);
assert_eq!(blob_vec.capacity(), 1_024);
}

#[derive(Debug, Eq, PartialEq, Clone)]
Expand Down Expand Up @@ -579,19 +581,19 @@ mod tests {

push(&mut blob_vec, foo3.clone());
assert_eq!(blob_vec.len(), 3);
assert_eq!(blob_vec.capacity(), 3);
assert_eq!(blob_vec.capacity(), 4);

let last_index = blob_vec.len() - 1;
let value = swap_remove::<Foo>(&mut blob_vec, last_index);
assert_eq!(foo3, value);

assert_eq!(blob_vec.len(), 2);
assert_eq!(blob_vec.capacity(), 3);
assert_eq!(blob_vec.capacity(), 4);

let value = swap_remove::<Foo>(&mut blob_vec, 0);
assert_eq!(foo1, value);
assert_eq!(blob_vec.len(), 1);
assert_eq!(blob_vec.capacity(), 3);
assert_eq!(blob_vec.capacity(), 4);

foo2.a = 8;
assert_eq!(get_mut::<Foo>(&mut blob_vec, 0), &foo2);
Expand Down

0 comments on commit a625547

Please sign in to comment.