Skip to content

Commit a9964f4

Browse files
authored
fix msaa shift with irradiance volumes in mesh pipeline key (#12845)
# Objective - #12791 broke example `irradiance_volumes` - Fixes #12876 ``` wgpu error: Validation Error Caused by: In Device::create_render_pipeline note: label = `pbr_opaque_mesh_pipeline` Color state [0] is invalid Sample count 8 is not supported by format Rgba8UnormSrgb on this device. The WebGPU spec guarentees [1, 4] samples are supported by this format. With the TEXTURE_ADAPTER_SPECIFIC_FORMAT_FEATURES feature your device supports [1, 2, 4]. ``` ## Solution - Shift bits a bit more
1 parent c233d6e commit a9964f4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

crates/bevy_pbr/src/render/mesh.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ bitflags::bitflags! {
576576

577577
impl MeshPipelineKey {
578578
const MSAA_MASK_BITS: u32 = 0b111;
579-
const MSAA_SHIFT_BITS: u32 = Self::LAST_FLAG.bits().trailing_zeros();
579+
const MSAA_SHIFT_BITS: u32 = Self::LAST_FLAG.bits().trailing_zeros() + 1;
580580

581581
const BLEND_MASK_BITS: u32 = 0b11;
582582
const BLEND_SHIFT_BITS: u32 = Self::MSAA_MASK_BITS.count_ones() + Self::MSAA_SHIFT_BITS;

0 commit comments

Comments
 (0)