typo and add comments

bevyengine · Mar 16, 2021 · ab62ffd · ab62ffd
1 parent a6c3e6d
commit ab62ffd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/crates/bevy_asset/src/asset_server.rs b/crates/bevy_asset/src/asset_server.rs
@@ -518,8 +518,8 @@ impl AssetServer {
                     transform,
                 }) => {
                     if let Some(original) = assets.get(from) {
-                        // `transform` can fail if it's result is not the expected type
-                        // this should happen as public API to reach this point is stronly typed
+                        // `transform` can fail if its result is not the expected type
+                        // this should not happen as public API to reach this point is stronly typed
                         // traits are only used in flight for communication
                         if let Ok(new) = transform(original) {
                             assets.set(to, *new);

diff --git a/crates/bevy_asset/src/loader.rs b/crates/bevy_asset/src/loader.rs
@@ -202,7 +202,14 @@ impl<T: AssetDynamic> AssetLifecycle for AssetLifecycleChannel<T> {
             .send(AssetLifecycleEvent::CreateNewFrom {
                 from,
                 to,
-                transform: Box::new(|asset: &T| transform(asset).downcast::<T>().map_err(|_| ())),
+                transform: Box::new(|asset: &T| {
+                    transform(asset)
+                        .downcast::<T>()
+                        // `downcast` can fail if `transform` result is not the expected type
+                        // this should not happen as public API to reach this point is stronly typed
+                        // traits are only used in flight for communication
+                        .map_err(|_| ())
+                }),
             })
             .unwrap();
     }