Skip to content

Commit

Permalink
HalfSpace is actually an open set
Browse files Browse the repository at this point in the history
  • Loading branch information
Selene-Amanita committed Jul 21, 2023
1 parent 4d506ca commit aeaef2d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions crates/bevy_render/src/primitives/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ impl Sphere {
}
}

/// A region of 3D space, specifically a closed set whose border is a bisecting 2D plane.
/// A region of 3D space, specifically an open set whose border is a bisecting 2D plane.
/// This bisecting plane partitions 3D space into two infinite regions,
/// the half-space is one of those regions and includes the bisecting plane.
/// the half-space is one of those regions and excludes the bisecting plane.
///
/// Each instance of this type is characterized by:
/// - the bisecting plane's unit normal, normalized and pointing "inside" the half-space,
Expand All @@ -120,7 +120,7 @@ impl Sphere {
///
/// Any point `p` is considered to be within the `HalfSpace` when the length of the projection
/// of p on the normal is greater or equal than the opposite of the distance,
/// meaning: if the equation `normal.dot(p) + distance >= 0.` is satisfied.
/// meaning: if the equation `normal.dot(p) + distance > 0.` is satisfied.
///
/// For example, the half-space containing all the points with a z-coordinate lesser
/// or equal than `8.0` would be defined by: `HalfSpace::new(Vec3::NEG_Z.extend(-8.0))`.
Expand Down

0 comments on commit aeaef2d

Please sign in to comment.