Skip to content

Commit

Permalink
Remove ExtractComponent::Out (#15926)
Browse files Browse the repository at this point in the history
# Objective

- `C: ExtractComponent` inserts `C::Out` instead of `C`, so we need to
remove `C::Out`. cc #15904.

## Solution

- `C` -> `C::Out`

## Testing

- CAS has `<ContrastAdaptiveSharpening as ExtractComponent>::Out =
(DenoiseCas, CasUniform)`. Setting its strength to zero correctly
removes the effect after this change.
  • Loading branch information
akimakinai authored Oct 15, 2024
1 parent ed35129 commit c78886e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions crates/bevy_render/src/extract_component.rs
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ fn extract_components<C: ExtractComponent>(
if let Some(component) = C::extract_component(query_item) {
values.push((entity, component));
} else {
commands.entity(entity).remove::<C>();
commands.entity(entity).remove::<C::Out>();
}
}
*previous_len = values.len();
Expand All @@ -226,7 +226,7 @@ fn extract_visible_components<C: ExtractComponent>(
if let Some(component) = C::extract_component(query_item) {
values.push((entity, component));
} else {
commands.entity(entity).remove::<C>();
commands.entity(entity).remove::<C::Out>();
}
}
}
Expand Down

0 comments on commit c78886e

Please sign in to comment.