Animation player jumps to the first frame after animation ends, instead of staying at the last frame #10480
Assignees
Labels
A-Animation
Make things move and change over time
C-Bug
An unexpected or incorrect behavior
P-Regression
Functionality that used to work but no longer does. Add a test for this!
Milestone
Comments
idanarye
added
C-Bug
nicopap
added
P-Regression
|
I've also reproduced this error today |
|
Same here after migrating from 0.11.3 to 0.12 |
|
Saw that as well. I was using morph targets/shape keys animation. |
|
working on it |
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 14, 2023
# Objective After #9002, it seems that "single shot" animations were broken. When completing, they would reset to their initial value. Which is generally not what you want. - Fixes #10480 ## Solution Avoid `%`-ing the animation after the number of completions exceeds the specified one. Instead, we early-return. This is also true when the player is playing in reverse. --- ## Changelog - Avoid resetting animations after `Repeat::Never` animation completion.
cart
pushed a commit
that referenced
this issue
Nov 30, 2023
# Objective After #9002, it seems that "single shot" animations were broken. When completing, they would reset to their initial value. Which is generally not what you want. - Fixes #10480 ## Solution Avoid `%`-ing the animation after the number of completions exceeds the specified one. Instead, we early-return. This is also true when the player is playing in reverse. --- ## Changelog - Avoid resetting animations after `Repeat::Never` animation completion.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this issue
Jan 9, 2024
# Objective After bevyengine#9002, it seems that "single shot" animations were broken. When completing, they would reset to their initial value. Which is generally not what you want. - Fixes bevyengine#10480 ## Solution Avoid `%`-ing the animation after the number of completions exceeds the specified one. Instead, we early-return. This is also true when the player is playing in reverse. --- ## Changelog - Avoid resetting animations after `Repeat::Never` animation completion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bevy version
Bevy v0.12.0
What you did
The problem happens when I start a non-repeating animation with the
AnimationPlayer. I've created a repository that demonstrates the problem: https://github.com/idanarye/demonstrate-bevy-0.12-animation-bugIn the demos, hit the Spacebar to start the animation. If you run them in WASM you'll probably need to click on the canvas first before it starts accepting keyboard input.
What went wrong
Additional information
Note that I'm using the same glb file I used when I found the problem. I've tried to replicate it with a simpler glb file, but with no success. So it is possible that something is wrong with my glb file (which is very likely - I had to import some lost animation from an old export to the blender file, which could have messed things up), but since it works just fine in Bevy v0.11 there may be an actual regression in Bevy v0.12.
The text was updated successfully, but these errors were encountered: