-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file_watcher
feature fails to build for wasm32
because notify-debounder-full
is only for native
#10507
Comments
simbleau
added
C-Bug
An unexpected or incorrect behavior
S-Needs-Triage
This issue needs to be labelled
labels
Nov 11, 2023
For those needing a fast solution:
|
simbleau
changed the title
Nov 11, 2023
bevy_asset
fails to build on wasm32 - notify-debounder-full
is only for nativefile_watcher
feature fails to build for wasm32
because notify-debounder-full
is only for native
alice-i-cecile
added
A-Assets
Load files from disk to use for things like images, models, and sounds
O-Web
Specific to web (WASM) builds
and removed
S-Needs-Triage
This issue needs to be labelled
labels
Nov 12, 2023
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 17, 2023
# Objective - Currently, in 0.12 there is an issue that it is not possible to build bevy for Wasm with feature "file_watcher" enabled. It still would not compile, but now with proper explanation. - Fixes #10507 ## Solution - Remove `notify-debouncer-full` dependency on WASM platform entirely. - Compile with "file_watcher" feature now on platform `wasm32` gives meaningful compile error. --- ## Changelog ### Fixed - Compile with "file_watcher" feature now on platform `wasm32` gives meaningful compile error.
cart
pushed a commit
that referenced
this issue
Nov 30, 2023
# Objective - Currently, in 0.12 there is an issue that it is not possible to build bevy for Wasm with feature "file_watcher" enabled. It still would not compile, but now with proper explanation. - Fixes #10507 ## Solution - Remove `notify-debouncer-full` dependency on WASM platform entirely. - Compile with "file_watcher" feature now on platform `wasm32` gives meaningful compile error. --- ## Changelog ### Fixed - Compile with "file_watcher" feature now on platform `wasm32` gives meaningful compile error.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this issue
Jan 9, 2024
# Objective - Currently, in 0.12 there is an issue that it is not possible to build bevy for Wasm with feature "file_watcher" enabled. It still would not compile, but now with proper explanation. - Fixes bevyengine#10507 ## Solution - Remove `notify-debouncer-full` dependency on WASM platform entirely. - Compile with "file_watcher" feature now on platform `wasm32` gives meaningful compile error. --- ## Changelog ### Fixed - Compile with "file_watcher" feature now on platform `wasm32` gives meaningful compile error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bevy version
What went wrong
we updated to using
notify-debouncer-full-0.3.1
inbevy-asset 0.12
:attempting to build for wasm32 will yield this lovely error:
The key phrase here is:
note: found an item that was configured out
this is because there is no
wasm32
family function forget_file_id
:https://github.com/notify-rs/notify/blob/c4d047078549c2fec0bbfada29653097776b8b2d/file-id/src/lib.rs#L110
Solution
file_watcher
should only bring innotify-debouncer-full
on non wasm targets, and do nothing for wasm targets, just as it did before.The text was updated successfully, but these errors were encountered: