Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a feature to Serialize in bevy_ui #11119

Closed
pablo-lua opened this issue Dec 28, 2023 · 0 comments · Fixed by #11188
Closed

Create a feature to Serialize in bevy_ui #11119

pablo-lua opened this issue Dec 28, 2023 · 0 comments · Fixed by #11188
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use

Comments

@pablo-lua
Copy link
Contributor

What problem does this solve or what need does it fill?

We would only implement Serialize/Deserialize when the user requests to

What solution would you like?

A creation of a cargo feature serialize in the bevy_ui crate

What alternative(s) have you considered?

Leave it as it is
@pablo-lua pablo-lua added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Dec 28, 2023
@matiqo15 matiqo15 added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Dec 28, 2023
@pablo-lua pablo-lua mentioned this issue Jan 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 3, 2024
@pablo-lua
Create serialize feature for bevy_ui (#11188)
41c3620 
# Objective

- Fixes #11119  

## Solution

- Creation of the serialize feature to ui

---

## Changelog

### Changed
- Changed all the structs that implement Serialize and Deserialize to
only implement when feature is on

## Migration Guide

- If you want to use serialize and deserialize with types from bevy_ui,
you need to use the feature serialize in your TOML
```toml
[dependencies.bevy]
features = ["serialize"]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create serialize feature for bevy_ui pablo-lua/bevy
2 participants
@matiqo15 @pablo-lua