Bevy depends on 4 different versions of the windows crate

[Veykril]

Bevy version

• Original: 0.12.1
• Current: 0.12.1

Relevant system information

❯ cargo --version
cargo 1.77.0-nightly (ac6bbb332 2023-12-26)

on windows 10

What's performing poorly?

This is not necessarily a regression, but it was the template that fits best. Bevy currently depends on 4 versions of the windows crate, namely 0.44.0, 0.46.0, 0.48.0 and 0.52.0:

windows v0.44.0
└── gpu-allocator v0.22.0
    └── wgpu-hal v0.17.2
        ├── wgpu v0.17.2
        │   └── bevy_render v0.12.1
        │       ├── bevy_animation v0.12.1
        │       │   ├── bevy_gltf v0.12.1 (*)
        │       │   └── bevy_internal v0.12.1 (*)
        │       ├── bevy_core_pipeline v0.12.1
        │       │   ├── bevy-inspector-egui v0.22.1 (*)
        │       │   ├── bevy_gizmos v0.12.1
        │       │   │   └── bevy_internal v0.12.1 (*)
        │       │   ├── bevy_gltf v0.12.1 (*)
        │       │   ├── bevy_internal v0.12.1 (*)
        │       │   ├── bevy_pbr v0.12.1
        │       │   │   ├── bevy-inspector-egui v0.22.1 (*)
        │       │   │   ├── bevy_gizmos v0.12.1 (*)
        │       │   │   ├── bevy_gltf v0.12.1 (*)
        │       │   │   └── bevy_internal v0.12.1 (*)
        │       │   ├── bevy_sprite v0.12.1
        │       │   │   ├── bevy_gizmos v0.12.1 (*)
        │       │   │   ├── bevy_internal v0.12.1 (*)
        │       │   │   ├── bevy_text v0.12.1
        │       │   │   │   ├── bevy_internal v0.12.1 (*)
        │       │   │   │   └── bevy_ui v0.12.1
        │       │   │   │       └── bevy_internal v0.12.1 (*)
        │       │   │   └── bevy_ui v0.12.1 (*)
        │       │   └── bevy_ui v0.12.1 (*)
        │       ├── bevy_gizmos v0.12.1 (*)
        │       ├── bevy_gltf v0.12.1 (*)
        │       ├── bevy_internal v0.12.1 (*)
        │       ├── bevy_pbr v0.12.1 (*)
        │       ├── bevy_scene v0.12.1
        │       │   ├── bevy_gltf v0.12.1 (*)
        │       │   └── bevy_internal v0.12.1 (*)
        │       ├── bevy_sprite v0.12.1 (*)
        │       ├── bevy_text v0.12.1 (*)
        │       └── bevy_ui v0.12.1 (*)
        └── wgpu-core v0.17.1
            └── wgpu v0.17.2 (*)

windows v0.46.0
└── cpal v0.15.2
    └── rodio v0.17.3
        └── bevy_audio v0.12.1
            └── bevy_internal v0.12.1
                └── bevy v0.12.1

windows v0.48.0
└── accesskit_windows v0.15.1
    └── accesskit_winit v0.15.0
        └── bevy_winit v0.12.1
            └── bevy_internal v0.12.1
                └── bevy v0.12.1

windows v0.52.0
└── gilrs-core v0.5.10
    └── gilrs v0.10.4
        └── bevy_gilrs v0.12.1
            └── bevy_internal v0.12.1
                └── bevy v0.12.1

This is a pretty big issue for rust-analyzer users at least (and I assume not too nice for compilation speed either). Why? Well, these crates are absolutely massive, and due to how rust-analyzer works (for the time being, ideally it wouldn't), rust-analyzer currently loads every source file into memory at start up for speed (and unfortunately duplicates this for normalizing file endings). This wastes a ton of memory due to the windows crate being enormous in source code size (a whopping 1.5 - 1.6gb!), and this is without any other related computed information like early name resolution which could be pretty big for these crates as well!

Now this is not a problem for bevy itself, but certainly for the user experience of people working with the engine in rust-analyzer so I figured I should bring this up.

Additional information

rust-lang/rust-analyzer#16301

[rlidwka]

cargo tree -d is a cool command, we should probably pay more attention to what it says

[mockersf]

it's known, Bevy CI used to fail on this... but not much we can do as the dependencies don't have all the same lifecycle.

it should "only" impact the build time and the bin size, not performance

[Veykril]

Well, feel free to close this. Just wanted to raise for awareness as r-a is kind of limited in what it can do here currently. I have a small idea that will get memory waste from this down by a third, gonna try implementing that next week, but that still leaves a lot of memory.

[Veykril]

Okay, rust-lang/rust-analyzer#16307 will get rid of the extra in memory source file stores, so this can be closed if you don't think this is a problem for you to track. I would seriously recommend though trying to get rid of windows crate duplication as it is just a really damn massive crate in terms of source size. Someone checking out rust + bevy for the first time will download 700mbs of source files to their crates io index just for those 4 crates.

[lnicola]

N.b.: that gets rid of the extra copy, but we still store all the source code of the four crates in memory (as described above).

[VirxEC]

At the very least, windows v0.44.0 will be dropped when 0.13 lands and wgpu is updated to 0.18.