-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "redirect" to the new plugin guidelines document #11272
Comments
Can you show me what those tracking badges look like? Your link doesn't seem correct. We should definitely not host this in the main repo (the book is that right spot for discoverability), but I would like to avoid recreating a brittle link again. |
Oops. I mean to link to the "main track branching" section of the document, but was unable to because the new document doesn't have header anchors. I am talking about these badges: |
Okay, improved the issue description. Sorry for the confusion. |
I think we can go with the PR quest option. The change would be a single link in a README file. - [![Bevy tracking](https://img.shields.io/badge/Bevy%20tracking-main-lightblue)](https://github.com/bevyengine/bevy/blob/main/docs/plugins_guidelines.md#main-branch-tracking)
+ [![Bevy tracking](https://img.shields.io/badge/Bevy%20tracking-main-lightblue)](https://bevyengine.org/learn/book/plugin-development/#main-branch-tracking) For released tracking - [![Bevy tracking](https://img.shields.io/badge/Bevy%20tracking-released%20version-lightblue)](https://github.com/bevyengine/bevy/blob/main/docs/plugins_guidelines.md#main-branch-tracking)
+ [![Bevy tracking](https://img.shields.io/badge/Bevy%20tracking-released%20version-lightblue)](https://bevyengine.org/learn/book/plugin-development/#main-branch-tracking) In both cases, only the link needs to be updated. We can also standardize the PR, like
I could go ahead and draft a list of the projects on the assets page using the badge with the broken links if we're going ahead with this. |
Another option if going the PR quest route might be to remove the link entirely in favor of alt text. Maybe this document is not a great landing spot for users clicking these badges. It is directly addressing the plugin author and might be confusing. |
I can see 2 potential issues with that approach.
An alternative to consider is to create Issues instead, as well as suggest the two options. i.e. update the link or use alt text. The author can then decide what they want to go with. Though this method could take longer to fix the links and the author could simply ignore the issue in which case it is up to them how to deal with that. |
Agreed on both counts. It would be much easier to open issues that direct the repo owners to the new docs. |
I'm going to close this. I feel like opening github issues on active projects is the way to go, so there's nothing to be done in this repo. If anyone's motivated to do / help do that, feel free to keep discussing here. |
Alright, seems like this is indeed the best possible solution. Of course it would be a good practice to check the tracking links before opening issues to avoid false positives. Here's a quick issue template I drafted, feel free to add to it or edit it if required.
Checklist - Bevy community assets page categories
I'll start creating issues in plugins from the 2D section for now. |
What problem does this solve or what need does it fill?
The plugin guidelines that used to be in this repo were moved here in #11242, but many third party plugins linked to this document in their READMEs by way of their "bevy tracking badges."
Those existing links in other projects are now broken. (Some examples in the wild: bevy_prototype_lyon, bevy-debug-text-overlay, bevy_framepace, bevy_easings, bevy_embedded_assets, bevy_panorbit_camera, bevy_tweening, bevy_polyline, bevy_infinite_grid, bevy_transform_gizmo. Not comprehensive.)
Should we add a placeholder document in the old location that just links to the new document?
I have a separate issue open in the bevy-website repo about the tags in the current document also having broken links. This issue is about old links in third party plugins being broken, and what we could do to fix that in this repo.
What alternative(s) have you considered?
Do nothing about this in the Bevy repo. Leave the broken links broken. Maybe go on a quest to submit PRs to a bunch of plugin repos to fix them.
The text was updated successfully, but these errors were encountered: