Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment map not working when using deferred rendering #11414

Closed
DGriffin91 opened this issue Jan 18, 2024 · 0 comments · Fixed by #11534
Closed

Environment map not working when using deferred rendering #11414

DGriffin91 opened this issue Jan 18, 2024 · 0 comments · Fixed by #11534
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-High This is particularly urgent, and deserves immediate attention

Comments

@DGriffin91
Copy link
Contributor

Bevy version 056b006

The deferred rendering example is missing environment map when set to use deferred.

The issue was introduced at 839d2f8 with #11152

b
a
@DGriffin91 DGriffin91 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jan 18, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Jan 18, 2024
@JMS55 JMS55 added the P-High This is particularly urgent, and deserves immediate attention label Jan 19, 2024
@atlv24 atlv24 mentioned this issue Jan 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 29, 2024
@atlv24 @JMS55
Fix specular envmap in deferred (#11534)
45967b0 
# Objective

- Fixes #11414

## Solution

- Add specular occlusion to g-buffer so PbrInput can be properly
reconstructed for shading with a non-zero value allowing the spec envmap
to be seen


![image](https://github.com/bevyengine/bevy/assets/11307157/84aa8312-7c06-4dc7-92da-5d94b54b133d)

---------

Co-authored-by: JMS55 <47158642+JMS55@users.noreply.github.com>
tjamaan pushed a commit to tjamaan/bevy that referenced this issue Feb 6, 2024
@atlv24 @JMS55 @tjamaan
Fix specular envmap in deferred (bevyengine#11534)
8e81f69 
# Objective

- Fixes bevyengine#11414

## Solution

- Add specular occlusion to g-buffer so PbrInput can be properly
reconstructed for shading with a non-zero value allowing the spec envmap
to be seen


![image](https://github.com/bevyengine/bevy/assets/11307157/84aa8312-7c06-4dc7-92da-5d94b54b133d)

---------

Co-authored-by: JMS55 <47158642+JMS55@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-High This is particularly urgent, and deserves immediate attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix specular envmap in deferred atlv24/bevy
3 participants
@alice-i-cecile @DGriffin91 @JMS55