Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some examples incorrectly use the Image color rather than background color #14097

Closed
alice-i-cecile opened this issue Jul 1, 2024 · 0 comments · Fixed by #14115
Closed

Some examples incorrectly use the Image color rather than background color #14097

alice-i-cecile opened this issue Jul 1, 2024 · 0 comments · Fixed by #14115
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@alice-i-cecile
Copy link
Member 

          I guess it was missed

bevy/examples/ui/button.rs

Line 32 in 336fddb

image.color = PRESSED_BUTTON;

bevy/examples/ui/button.rs

Line 37 in 336fddb

image.color = HOVERED_BUTTON;

bevy/examples/ui/button.rs

Line 42 in 336fddb

image.color = NORMAL_BUTTON;

Originally posted by @lufog in #14017 (review)
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples A-UI Graphical user interfaces, styles, layouts, and widgets S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon labels Jul 1, 2024
@mockersf mockersf mentioned this issue Jul 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 3, 2024
@mockersf
fix remaining issues with background color in examples (#14115)
160bcc7 
# Objective

- Fixes #14097

## Solution

- Switching the uses of `UiImage` in examples to `BackgroundColor` when
needed
mockersf added a commit that referenced this issue Jul 3, 2024
@mockersf
fix remaining issues with background color in examples (#14115)
ff070da 
# Objective

- Fixes #14097

## Solution

- Switching the uses of `UiImage` in examples to `BackgroundColor` when
needed
zmbush pushed a commit to zmbush/bevy that referenced this issue Jul 3, 2024
@mockersf @zmbush
fix remaining issues with background color in examples (bevyengine#14115
667624c 
)

# Objective

- Fixes bevyengine#14097

## Solution

- Switching the uses of `UiImage` in examples to `BackgroundColor` when
needed
MrGVSV pushed a commit to MrGVSV/bevy that referenced this issue Jul 5, 2024
@mockersf @MrGVSV
fix remaining issues with background color in examples (bevyengine#14115
51a3081 
)

# Objective

- Fixes bevyengine#14097

## Solution

- Switching the uses of `UiImage` in examples to `BackgroundColor` when
needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix remaining issues with background color in examples mockersf/bevy
1 participant
@alice-i-cecile